fix: LiXee ZLinky: handle empty TIC command list #10519
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbraz
changed the title
sbraz
force-pushed
the
zlinky_tic_whitelist
branch
2 times, most recently
from
59bc1a9 to
a95244d
Compare
sbraz
commented
Oct 25, 2025
src/devices/lixee.ts
Outdated
| e | ||
| .text("tic_command_whitelist", ea.SET) | ||
| .withDescription("List of TIC commands to be exposed (separated by comma). Reconfigure device after change. Default: all"), | ||
| .withDescription("List of TIC commands to be exposed (separated by comma). Requires Z2M restart. Default: all"), |
Contributor
Author
There was a problem hiding this comment.
@Koenkk I found that changing the poll interval triggers an update of the list but I think it's better to just suggest a restart.
If the user defines a value for tic_command_whitelist and then clears it, it remains in the configuration as an empty string. An empty string should be the same as no value at all. Before this change, when the string was empty, no attributes were polled. Let's also suggest a Z2M restart in the description, it's the easiest way to restart the poll.
sbraz
force-pushed
the
zlinky_tic_whitelist
branch
from
a95244d to
a8560e8
Compare
Owner
|
Thanks! |
jacky202509
pushed a commit
to jacky202509/zigbee-herdsman-converters
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user defines a value for tic_command_whitelist and then clears
it, it remains in the configuration as an empty string.
An empty string should be the same as no value at all. Before this
change, when the string was empty, no attributes were polled.
Let's also suggest a Z2M restart in the description, it's the easiest way to
restart the poll.